Color string format does not accept by Edge/Chrome after saved by SvgDocument.Write

[mzh3511]

Hello, thanks again for your 0.6.0-preview8.2 version, when I use it I found another issue as follows:

I have a simple svg file, it's content:

<svg width="100%" height="100%" viewBox="0 0 100 100"
     xmlns="http://www.w3.org/2000/svg">

  <circle cx="50" cy="50" r="40" style="fill:#f10;stroke:Blue;"/>
</svg>

I opened the svg file and save it to another file, the codes are the following:

        _svgDocument = SvgDocument.Open(@"g:\demo2.svg");
        _svgDocument.Write(@"g:\demo2_1.svg");

I got the demo2_2.svg, its content:

<?xml version="1.0" encoding="utf-8"?>
<!DOCTYPE svg PUBLIC "-//W3C//DTD SVG 1.1//EN" "http://www.w3.org/Graphics/SVG/1.1/DTD/svg11.dtd">
<svg version="1.1" xmlns="http://www.w3.org/2000/svg" xmlns:xlink="http://www.w3.org/1999/xlink" xmlns:xml="http://www.w3.org/XML/1998/namespace" width="100%" height="100%" viewBox="0, 0, 100, 100">
  <circle cx="50" cy="50" r="40" style="fill:255, 17, 0;stroke:'Blue';" />
</svg>

But when I open the resaved svg by Edge or Chrome, the svg can not display correctly, although it can display by my codes:

We can see the circle shape style in svg is not recognized.

I investigated the wieslawsoltes/SVG and svg-net/SVG, and found that this may be because of the conditional compilation symbol (NO_SDC ) in line200 in SvgColourConverter.cs:

I use svg-net/SVG with the same codes, its resaved svg file content:

<?xml version="1.0" encoding="utf-8"?>
<!DOCTYPE svg PUBLIC "-//W3C//DTD SVG 1.1//EN" "http://www.w3.org/Graphics/SVG/1.1/DTD/svg11.dtd">
<svg version="1.1" xmlns="http://www.w3.org/2000/svg" xmlns:xlink="http://www.w3.org/1999/xlink" xmlns:xml="http://www.w3.org/XML/1998/namespace" width="100%" height="100%" viewBox="0, 0, 100, 100">
  <circle cx="50" cy="50" r="40" style="fill:#FF1100;stroke:blue;" />
</svg>

Please compare the style attribute value in the 2 resaved svg files, this is the reason, but I do not know why you add the conditional compilation symbol (NO_SDC ), can you explain?

Thanks!

[mzh3511]

@wieslawsoltes I pushed a pull request to fix the issue in svg-net/SVG repository, see PR1055, can you merge in and release a new NuGet package, please? Thanks

[mzh3511]

Hello, can you help me?

[mzh3511]

0.6.0-rc1.1 applied the change