Fix factory deps and re-deployment #541
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks @novaknole I ll merge that in and any issues later we can fix, Does not seem to change other behavior in any case |
|
available now in 0.12.4 |
|
Amazing, Thank you ^_^ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There were 2 very important problems with the deployment of zksync.
It was the "the hash code is not known" problem and clearly, constructing the factory deps wasn't done in a correct way. See my issue: factoryDepths for zksync is incorrectly built #537
The check to see whether it must re-deploy the contract or not was also misbehaving. Before this PR, the code was parsing the following
transaction.datawithrlp.decode, but sincetransaction.datais abi encoded string, this failed. You would notice that when re-deploying the contracts(instead of successfully skipping the deployments, it would fail).Note that I haven't taken a good look into predeterminsitic deployments on zksync, but since i am not using it and I don't have lots of time, for now, this PR is all I can do. Tagging @wighawag for visibility.