[WIP] Refactor of score processing pattern #144
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
halfak
force-pushed
the
structure_refactor
branch
2 times, most recently
from
70e5366
to
83fa052
Compare
|
It seems like there's a mixture of moving files and changing functionality. For ease of reviewing (and future maintenance), could the commit be broken down into more atomic parts? |
|
I think the confusion largely comes from github not showing you clean diffs of files that were renamed. I'm not sure why that is the case. |
halfak
force-pushed
the
structure_refactor
branch
6 times, most recently
from
64dbb64
to
f82bff6
Compare
halfak
force-pushed
the
structure_refactor
branch
from
f82bff6
to
2385aec
Compare
… extraction and updates to applications.
…ts version to 0.8.0.
|
Closing in favor of #155 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.