Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adds PrintablePageAsOfRevision view that uses an iframe #168

Merged
merged 2 commits into from
Mar 21, 2017

Conversation

halfak
Copy link
Member

@halfak halfak commented Mar 20, 2017

No description provided.

@halfak halfak mentioned this pull request Mar 20, 2017
@Ladsgroup
Copy link
Member

I tried to test it in labels-experiment but it didn't work the way I expected: http://labels-experiment.wmflabs.org/ui/wikidatawiki/
image

Also the widening looks good on wikidata but I don't like this for other wikis. Can we make it configurable?

@halfak
Copy link
Member Author

halfak commented Mar 21, 2017

@Ladsgroup: Strangely, that screenshot seems to be using the old PageAsOfRevision view rather than the PrintablePageAsOfRevision. I can tell by the color of some things. However, I think you make a good point about the change to width. Let me see how that might be addressed.

@halfak
Copy link
Member Author

halfak commented Mar 21, 2017

OK i brought the width back under control. I also did a little bit of styling with the PrintablePageAsOfRevision view so that it will not cause weird scroll bars as often.

@Ladsgroup Ladsgroup merged commit 0d76c1d into master Mar 21, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants