Template tools spike #3
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tpluscode
commented
Nov 30, 2016
| @@ -67,7 +68,12 @@ public Brochure CreateBrochure(EntityWrapper<BrochureEntity> source) | |||
| { | |||
| var target = new Brochure | |||
| { | |||
| Id = this.templates.CreateBrochureIdentifier(source.Entity.Id) | |||
| Id = IdentifierOf<Brochure>.Bind( | |||
There was a problem hiding this comment.
IdentifierOf<T>#Bind definitely need an object overload for using like
IdentifierOf<Brochure>.Bind(new { id: source.Entity.Id })
tpluscode
commented
Nov 30, 2016
| { | ||
| ["id"] = source.Entity.Id | ||
| }, | ||
| this.configuration.BaseResourceNamespace) |
There was a problem hiding this comment.
This where the caller can add a base URI to append to the template
tpluscode
commented
Nov 30, 2016
| @@ -44,7 +48,7 @@ public Magazine GetMagazine(Uri identifier) | |||
| [return: AllowNull] | |||
| public Brochure GetBrochure(Uri identifier) | |||
| { | |||
| var id = this.identifierRetriever.GetBrochureId(identifier); | |||
| var id = IdentifierOf<Brochure>.Match(identifier, this.config.BaseResourceNamespace).Get<int?>("id"); | |||
There was a problem hiding this comment.
Same here with the base. If the identifier is a complete URI it is possible to add it. Only needed when the actual template is a just the path
tpluscode
commented
Nov 30, 2016
| @@ -32,7 +31,7 @@ public SourcesModule(ISourcesRepository repository, IWikibusConfiguration config | |||
|
|
|||
| this.ReturnNotFoundWhenModelIsNull(); | |||
|
|
|||
| this.Get(Id.BrochurePath, r => this.GetSingle(repository.GetBrochure)); | |||
| this.Get<Brochure>(r => this.GetSingle(repository.GetBrochure)); | |||
There was a problem hiding this comment.
Inheriting from ArgolisModule makes it possible to add actions without specifying the path. It's taken from the attribute
Conflicts: paket.dependencies paket.lock src/data.wikibus.org/Web.config src/data.wikibus.org/data.wikibus.org.csproj src/wikibus.nancy/EntryPoint.cs src/wikibus.nancy/app.config src/wikibus.nancy/paket.references src/wikibus.nancy/wikibus.nancy.csproj src/wikibus.org/wikibus.org.csproj src/wikibus.purl.nancy/wikibus.purl.nancy.csproj src/wikibus.sources.EF/EntityFactory.cs src/wikibus.sources.EF/IdRetriever.cs src/wikibus.sources.EF/SourceRepositoryExtensions.cs src/wikibus.sources.EF/SourcesRepository.cs src/wikibus.sources.EF/paket.references src/wikibus.sources.EF/wikibus.sources.EF.csproj src/wikibus.sources.dotNetRDF/SourcesRepository.cs src/wikibus.sources.dotNetRDF/paket.references src/wikibus.sources.dotNetRDF/wikibus.sources.dotNetRDF.csproj src/wikibus.sources.nancy/SourcesModule.cs src/wikibus.sources.nancy/app.config src/wikibus.sources.nancy/paket.references src/wikibus.sources.nancy/wikibus.sources.nancy.csproj src/wikibus.sources/Book.cs src/wikibus.sources/Brochure.cs src/wikibus.sources/ISourcesRepository.cs src/wikibus.sources/IdentifierTemplates.cs src/wikibus.sources/Issue.cs src/wikibus.sources/Magazine.cs src/wikibus.sources/paket.references src/wikibus.sources/wikibus.sources.csproj src/wikibus.tests/Modules/Bindings/GettingSourcesSteps.cs src/wikibus.tests/Modules/Bindings/NancyDependencies.cs src/wikibus.tests/paket.references src/wikibus.tests/sources.EF/EntityFrameworkSourceTestContext.cs src/wikibus.tests/wikibus.tests.csproj src/wikibus.vehicles.nancy/wikibus.vehicles.nancy.csproj
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.