Parametrize code variables in bot.py to match each wikipedia configuration file #46
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…n to produce results.txt file
This was referenced Oct 12, 2023
wikicurricula-uy
requested changes
Oct 16, 2023
There was a problem hiding this comment.
Hello, @Bhbee! I don't understand why is it necesary to create a serialize_data.py file.
Can't you just create wikipedia_config.json and (maybe) a language_template_config.json?
In an ideal scenario, adding support for a new language should only require us to edit a .json. It should not require us to edit a script.
data-gathering/bot.py
Outdated
|
|
||
| article2 = article2[:article2.find("]]")] | ||
| if "#RINVIA" in wikitext: |
There was a problem hiding this comment.
Is #RINVIA an equivalent to #REDIRECT? Does it work for all languages?
There was a problem hiding this comment.
No, it doesnt work for all languages. I'll add checking for "REDIRECT" too
remove accidental message
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes #11. Previously bot.py worked only with the Spanish Wikipedia.
But after parameterizing, it currently can work with several Wikipedias present in the newly created "wikipedia_config.json" file which is generated by the newly created "serialize_data.py" script.
The serialize_data.py can be edited to add the required information of other Wikipedias that are not available in the file.
For example, to add Ghana Wikipedia, add to the dictionary the correct keys and values for Ghana Wikipedia config:
wikipedia_config = {
"es": {
"file_to_be_analysed": "query.csv",
"language": "es"
},
"it": {.....},
"ak": {
"file_to_be_analysed": "ghana.csv",
"language": "ak"
}
}
To generate the result of the analysis:(results.txt) file, you can run the bot.py script like this:
python bot.py enor
python3 bot.py enwhere en is the initial for the English Wikipedia. This can be changed to the initial of any desired Wikipedia.
for example
python bot.py esCreated a "default.csv" file to test the English Wikipedia configuration. Hence the new "results.txt file"
This PR also takes into consideration the comment of @wikicurricula-uy on PR #17 which was closed about the separation of solutions.