Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create he.js #5

Merged
merged 3 commits into from Jul 27, 2021
Merged

Create he.js #5

merged 3 commits into from Jul 27, 2021

Conversation

Uziel302
Copy link
Contributor

No description provided.

@Joeytje50
Copy link
Collaborator

Joeytje50 commented Apr 18, 2021

In order to work, the new language file will need to be added to i18n.js itself as well (under the comment // List all languages here:). If you can add that I'll merge both changes to master and make the changes to the live JWB as well.

@Uziel302
Copy link
Contributor Author

Uziel302 commented Jul 7, 2021

Done that long ago, how shall we proceed?

@Rexogamer
Copy link

I think having all the changes in one PR would help (cherrypick the commit from the other branch, then close the other PR).

@Uziel302
Copy link
Contributor Author

I think having all the changes in one PR would help (cherrypick the commit from the other branch, then close the other PR).

Done

@Joeytje50
Copy link
Collaborator

Although I don't know any Hebrew, the format looks good, so I'll merge it and deploy it to the live JWB script as well.

@Joeytje50 Joeytje50 merged commit 806e30e into wikimedia-gadgets:master Jul 27, 2021
@Uziel302
Copy link
Contributor Author

Now I need explanation how to use the file because just switching to the main project i18n file switches the language to english

@Joeytje50
Copy link
Collaborator

Apologies, that was another bug unrelated to the addition of the Hebrew i18n file. This issue should be resolved now. I will update the github repo momentarily.

@Uziel302
Copy link
Contributor Author

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants