Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove {{promising draft}}, and unify template removal logic #189

Merged
merged 1 commit into from Dec 28, 2021
Merged

Remove {{promising draft}}, and unify template removal logic #189

merged 1 commit into from Dec 28, 2021

Conversation

siddharthvp
Copy link
Member

@siddharthvp siddharthvp commented Nov 4, 2021 •
edited

also a cosmetic 2nd commit that changes all '~~' + '~~' to ~~~~.

Closes #167.

@enterprisey
Copy link
Contributor

Thanks for the patch. I'm a little worried about fixing the signature stuff. I know the scripts are wrapped in nowiki tags, but it still feels a little risky. Would you object to leaving the signature changes out?

@siddharthvp
Copy link
Member Author

It should have been fine, but removed anyway

@enterprisey
Copy link
Contributor

Thanks!

@enterprisey enterprisey merged commit 24029d8 into master Dec 28, 2021
@siddharthvp siddharthvp deleted the templateremoval branch February 17, 2022 13:38
ptsgrn added a commit to ptsgrn/afch-rewrite that referenced this pull request Mar 2, 2022
@ptsgrn @dikshatakyar
@enterprisey @siddharthvp @gullyn
sync with upstream (#3)
b69ac92 
* replaced https with http (wikimedia-gadgets#207)

* Updates to server.js: new setup

* properly enable mockItUp in server.js

* Show live preview while writing comments (wikimedia-gadgets#199)

* Handle slashes in article titles (wikimedia-gadgets#198)

Closes wikimedia-gadgets#110.

* Add comment to title subpage logic

* show copyvio warning (wikimedia-gadgets#197)

* Avoid use of deprecated token types (wikimedia-gadgets#192)

'edit' and 'options' token types are deprecated in favour of csrf token. Have used the function postWithEditToken() here that uses csrf token - which should be more stable than using `postWithToken( 'csrf', ... )`.

* Remove {{promising draft}}, and unify template removal logic (wikimedia-gadgets#189)

* update readme: npm start runs npm install automatically

* Remove acceptance form fields whose values aren't used (wikimedia-gadgets#191)

Values entered here have been unused since persondata was removed in wikimedia-gadgets@9632e4fd (2015).

* Use toolforge cdn's hogan, fixing licensing issue

https://en.wikipedia.org/wiki/Wikipedia:Miscellany_for_deletion/MediaWiki:Gadget-afchelper.js/core.js

* Revert "Use toolforge cdn's hogan, fixing licensing issue "

This reverts commit 7b87347.

* server.js: clarify instructions

* Log page name for mockItUp edits

* resolve nowiki issue

when this was uploaded, the hogan part would contain some stuff that
would get misread as a mediawiki template, so this change adds a
"banner" in the grunt concat config that puts a nowiki tag at the top
(and, as a side effect - hopefully harmless - a random nowiki in the
middle).

* Fix comment preview (wikimedia-gadgets#218)

- fix afc comment template - previous version did not work with some custom signatures
- hide comment preview after text box is emptied

* Show live preview for decline/reject reasons (wikimedia-gadgets#211)

As requested en.wikipedia.org/w/index.php?title=Wikipedia_talk:WikiProject_Articles_for_creation&diff=1066284130

* Add warning is submitter is blocked (wikimedia-gadgets#219)

* Support adding/editing short description (wikimedia-gadgets#196)

Co-authored-by: Diksha <75247382+dikshatakyar@users.noreply.github.com>
Co-authored-by: Enterprisey <danielhglus@gmail.com>
Co-authored-by: Siddharth VP <siddharthvp@gmail.com>
Co-authored-by: gullyn <74876079+gullyn@users.noreply.github.com>
ptsgrn added a commit to ptsgrn/afch-rewrite that referenced this pull request Apr 17, 2022
@ptsgrn @dikshatakyar
@enterprisey @siddharthvp @gullyn
merge update to master (#4)
d8746f5 
* replaced https with http (wikimedia-gadgets#207)

* Updates to server.js: new setup

* properly enable mockItUp in server.js

* Show live preview while writing comments (wikimedia-gadgets#199)

* Handle slashes in article titles (wikimedia-gadgets#198)

Closes wikimedia-gadgets#110.

* Add comment to title subpage logic

* show copyvio warning (wikimedia-gadgets#197)

* Avoid use of deprecated token types (wikimedia-gadgets#192)

'edit' and 'options' token types are deprecated in favour of csrf token. Have used the function postWithEditToken() here that uses csrf token - which should be more stable than using `postWithToken( 'csrf', ... )`.

* Remove {{promising draft}}, and unify template removal logic (wikimedia-gadgets#189)

* update readme: npm start runs npm install automatically

* Remove acceptance form fields whose values aren't used (wikimedia-gadgets#191)

Values entered here have been unused since persondata was removed in wikimedia-gadgets@9632e4fd (2015).

* Use toolforge cdn's hogan, fixing licensing issue

https://en.wikipedia.org/wiki/Wikipedia:Miscellany_for_deletion/MediaWiki:Gadget-afchelper.js/core.js

* Revert "Use toolforge cdn's hogan, fixing licensing issue "

This reverts commit 7b87347.

* server.js: clarify instructions

* Log page name for mockItUp edits

* resolve nowiki issue

when this was uploaded, the hogan part would contain some stuff that
would get misread as a mediawiki template, so this change adds a
"banner" in the grunt concat config that puts a nowiki tag at the top
(and, as a side effect - hopefully harmless - a random nowiki in the
middle).

* Fix comment preview (wikimedia-gadgets#218)

- fix afc comment template - previous version did not work with some custom signatures
- hide comment preview after text box is emptied

* Show live preview for decline/reject reasons (wikimedia-gadgets#211)

As requested en.wikipedia.org/w/index.php?title=Wikipedia_talk:WikiProject_Articles_for_creation&diff=1066284130

* Add warning is submitter is blocked (wikimedia-gadgets#219)

* Support adding/editing short description (wikimedia-gadgets#196)

* l10n after sync with updtream

Co-authored-by: Diksha <75247382+dikshatakyar@users.noreply.github.com>
Co-authored-by: Enterprisey <danielhglus@gmail.com>
Co-authored-by: Siddharth VP <siddharthvp@gmail.com>
Co-authored-by: gullyn <74876079+gullyn@users.noreply.github.com>
ptsgrn added a commit to ptsgrn/afch-rewrite that referenced this pull request Aug 21, 2022
@ptsgrn @dikshatakyar
@enterprisey @siddharthvp @gullyn @GeoffreyTrang @NovemLinguae
WPAFC upstream update (#7)
924ad35 
* replaced https with http (wikimedia-gadgets#207)

* Updates to server.js: new setup

* properly enable mockItUp in server.js

* Show live preview while writing comments (wikimedia-gadgets#199)

* Handle slashes in article titles (wikimedia-gadgets#198)

Closes wikimedia-gadgets#110.

* Add comment to title subpage logic

* show copyvio warning (wikimedia-gadgets#197)

* Avoid use of deprecated token types (wikimedia-gadgets#192)

'edit' and 'options' token types are deprecated in favour of csrf token. Have used the function postWithEditToken() here that uses csrf token - which should be more stable than using `postWithToken( 'csrf', ... )`.

* Remove {{promising draft}}, and unify template removal logic (wikimedia-gadgets#189)

* update readme: npm start runs npm install automatically

* Remove acceptance form fields whose values aren't used (wikimedia-gadgets#191)

Values entered here have been unused since persondata was removed in wikimedia-gadgets@9632e4fd (2015).

* Use toolforge cdn's hogan, fixing licensing issue

https://en.wikipedia.org/wiki/Wikipedia:Miscellany_for_deletion/MediaWiki:Gadget-afchelper.js/core.js

* Revert "Use toolforge cdn's hogan, fixing licensing issue "

This reverts commit 7b87347.

* server.js: clarify instructions

* Log page name for mockItUp edits

* resolve nowiki issue

when this was uploaded, the hogan part would contain some stuff that
would get misread as a mediawiki template, so this change adds a
"banner" in the grunt concat config that puts a nowiki tag at the top
(and, as a side effect - hopefully harmless - a random nowiki in the
middle).

* Fix comment preview (wikimedia-gadgets#218)

- fix afc comment template - previous version did not work with some custom signatures
- hide comment preview after text box is emptied

* Show live preview for decline/reject reasons (wikimedia-gadgets#211)

As requested en.wikipedia.org/w/index.php?title=Wikipedia_talk:WikiProject_Articles_for_creation&diff=1066284130

* Add warning is submitter is blocked (wikimedia-gadgets#219)

* Support adding/editing short description (wikimedia-gadgets#196)

* Add missing parentheses to Line 2559 to fix wikimedia-gadgets#103 (wikimedia-gadgets#224)

This fixes wikimedia-gadgets#103 by adding missing parentheses to Line 2559 so that the part before "isDecline ? 'declined' : 'rejected'" correctly appears in the edit summary.

* fix toomanyvalues API error (wikimedia-gadgets#239)

* switch to GitHub Actions continuous integration (wikimedia-gadgets#236)

* style: eslinting

Co-authored-by: Diksha <75247382+dikshatakyar@users.noreply.github.com>
Co-authored-by: Enterprisey <danielhglus@gmail.com>
Co-authored-by: Siddharth VP <siddharthvp@gmail.com>
Co-authored-by: gullyn <74876079+gullyn@users.noreply.github.com>
Co-authored-by: GeoffreyTrang <geoffreytrang@gmail.com>
Co-authored-by: NovemLinguae <79697282+NovemLinguae@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

When accepting, remove {{Promising draft}} tag
2 participants
@siddharthvp @enterprisey