Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove acceptance form fields whose values aren't used #191

Merged
merged 1 commit into from
Dec 28, 2021
Merged

Remove acceptance form fields whose values aren't used #191

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 0 additions & 10 deletions src/modules/submissions.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1642,16 +1642,6 @@
}
prefillBiographyDetails();

// Ask for the month/day IF the birth year has been entered
$afch.find( '#birthYear' ).keyup( function () {
$afch.find( '#birthMonthDayWrapper' ).toggleClass( 'hidden', !this.value.length );
} );

// Ask for the month/day IF the death year has been entered
$afch.find( '#deathYear' ).keyup( function () {
$afch.find( '#deathMonthDayWrapper' ).toggleClass( 'hidden', !this.value.length );
} );

// If subject is dead, show options for death details
$afch.find( '#lifeStatus' ).change( function () {
$afch.find( '#deathWrapper' ).toggleClass( 'hidden', $( this ).val() !== 'dead' );
Expand Down
25 changes: 0 additions & 25 deletions src/templates/tpl-submissions.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -122,26 +122,11 @@
<input type="text" id="subjectName" class="afch-input afch-textfield" placeholder="Magellan, Ferdinand"/>
</div>

<div id="subjectDescriptionWrapper">
<label for="subjectDescription" class="afch-label">Description of the subject</label>
<input type="text" id="subjectDescription" class="afch-input afch-textfield" placeholder="Sea explorer"/>
</div>

<div id="birthYearWrapper">
<label for="birthYear" class="afch-label">Year of birth</label>
<input type="text" id="birthYear" class="afch-input afch-textfield" placeholder="1901"/>
</div>

<div id="birthMonthDayWrapper" class="hidden">
<label for="birthMonthDay" class="afch-label">Month and day of birth</label>
<input type="text" id="birthMonthDay" class="afch-input afch-textfield" placeholder="November 2"/>
</div>

<div id="birthPlaceWrapper">
<label for="birthPlace" class="afch-label">Place of birth</label>
<input type="text" id="birthPlace" class="afch-input afch-textfield" placeholder="Memphis, Tennessee"/>
</div>

<div id="lifeStatusWrapper">
<label for="lifeStatus" class="afch-label">Is the subject alive?</label>
<select id="lifeStatus" class="afch-input">
Expand All @@ -158,16 +143,6 @@
<input type="text" id="deathYear" class="afch-input afch-textfield" placeholder="1999"/>
</div>

<div id="deathMonthDayWrapper" class="hidden">
<label for="deathMonthDay" class="afch-label">Month and day of death</label>
<input type="text" id="deathMonthDay" class="afch-input afch-textfield" placeholder="December 13"/>
</div>

<div id="deathPlaceWrapper">
<label for="deathPlace" class="afch-label">Place of death</label>
<input type="text" id="deathPlace" class="afch-input afch-textfield" placeholder="London, England"/>
</div>

</div>

</div>
Expand Down