Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

tag: Stuck in "Adding supported tags inside existing {{multiple issues}} tag" #1058

Closed
Xi-Plus opened this issue Jul 21, 2020 · 2 comments · Fixed by #1060
Closed

tag: Stuck in "Adding supported tags inside existing {{multiple issues}} tag" #1058

Xi-Plus opened this issue Jul 21, 2020 · 2 comments · Fixed by #1060
Labels
bug Module: morebits The morebits.js library Module: tag

Comments

@Xi-Plus
Copy link
Contributor

Xi-Plus commented Jul 21, 2020

If there is no "UngroupedTags", tagText is "" in L1533.
https://github.com/azatoth/twinkle/blob/2b6f9a76a2cff95dd9d33c26a9beae416f318357/modules/friendlytag.js#L1515-L1536
And throw error in
https://github.com/azatoth/twinkle/blob/2b6f9a76a2cff95dd9d33c26a9beae416f318357/morebits.js#L4009-L4012
@Xi-Plus Xi-Plus mentioned this issue Jul 21, 2020
Merged
@Amorymeltzer
Copy link
Collaborator

Word. You've fixed it on your end one way, I'm inclined to say that's not a bad idea. I'm mixed on whether the lack of tag should throw or just return this (doubting myself) but I suppose checking that they're actually provided is better than just if (tagText) in tag...

Amorymeltzer added a commit to Amorymeltzer/twinkle that referenced this issue Jul 21, 2020
@Amorymeltzer
morebits: insertAfterTemplates: Only throw if undefined aka not provided
50e51eb 
xiplus-mediawiki-programs/twinkle@f4fd970, Closes wikimedia-gadgets#1058

Co-Authored by: xiplus <huangxuanyuxiplus@gmail.com>
@Amorymeltzer Amorymeltzer mentioned this issue Jul 21, 2020
Merged
Amorymeltzer added a commit to Amorymeltzer/twinkle that referenced this issue Jul 21, 2020
@Amorymeltzer
morebits: insertAfterTemplates: Only throw if undefined aka not provided
c853291 
xiplus-mediawiki-programs/twinkle@f4fd970, Closes wikimedia-gadgets#1058

Co-authored by: xiplus <huangxuanyuxiplus@gmail.com>
@Amorymeltzer
Copy link
Collaborator

Replicated in #1060

wiki-ST47 pushed a commit to wiki-ST47/twinkle that referenced this issue Sep 2, 2020
@Amorymeltzer @wiki-ST47
morebits: insertAfterTemplates: Only throw if undefined aka not provided
c32318a 
xiplus-mediawiki-programs/twinkle@f4fd970, Closes wikimedia-gadgets#1058

Co-authored by: xiplus <huangxuanyuxiplus@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Module: morebits The morebits.js library Module: tag
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

morebits: insertAfterTemplates: Only throw if undefined aka not provided Amorymeltzer/twinkle
2 participants
@Amorymeltzer @Xi-Plus