Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

{{welcome-short}} should add a heading #1785

Closed
NovemLinguae opened this issue May 25, 2023 · 1 comment
Closed

{{welcome-short}} should add a heading #1785

NovemLinguae opened this issue May 25, 2023 · 1 comment

Comments

@NovemLinguae
Copy link
Member

NovemLinguae commented May 25, 2023

I tried to welcome a new user with no user talk page created yet using {{welcome-short}}, and it added the welcome template, but without a heading.

https://en.wikipedia.org/w/index.php?title=User_talk:Msx_4544&oldid=1156981560

image

Would be better if Twinkle added a heading named == Welcome ==

image

Needs testing. Is this bug for all welcome templates or just {{welcome-short}}? Does this occur only when the user talk page is uncreated?

Finally, there are 2 newlines at the top that should probably be removed.

image
@NovemLinguae
Copy link
Member Author

I checked the other welcome templates, and they all hard-code their == Welcome! ==. Twinkle does not add it. So I have modified Template:W-short to include this heading. That should fix this bug.

NovemLinguae added a commit to NovemLinguae/twinkle that referenced this issue Jun 23, 2023
- add comment
- capitalize a template name
- remove dead code (the template W-short does not support the parameter heading=true)

Related wikimedia-gadgets#1785
NovemLinguae added a commit that referenced this issue Jul 19, 2023
- add comment
- capitalize a template name
- remove dead code (the template W-short does not support the parameter heading=true)

Related #1785
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant