Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Twinkle should use OOUI #414

Open
Huji opened this issue Mar 20, 2018 · 4 comments
Open

Twinkle should use OOUI #414

Huji opened this issue Mar 20, 2018 · 4 comments

Comments

@Huji
Copy link
Contributor

Huji commented Mar 20, 2018

Currently, Twinkle uses jQuery.tipsy and other similar modules that are considered deprecated by MediaWiki's ResourceLoader. It also uses jQuery UI to draw its menus.

Since everything in MediaWiki is moving in the direction of OOUI, so should Twinkle.

@atlight
Copy link
Collaborator

atlight commented Mar 20, 2018

See #384 for some relevant discussion.

@Huji
Copy link
Contributor Author

Huji commented Mar 20, 2018

Noted. My understanding of #384 is that, in essence, you had "We don't have any plans to move away from jQuery UI at the moment."

It is okay if you want to close this issue now; however, alternatively, we can keep it open for when the issue of movability of dialogues is addressed in OOUI. Is there a Phab ticket opened for it?

@atlight
Copy link
Collaborator

atlight commented Mar 20, 2018

Let's keep it open; I'm not sure why the other issue was closed.

The relevant Phabricator task is https://phabricator.wikimedia.org/T51969. Bartosz's suggestion of a split-screen interface is interesting; I can imagine a fixed panel appearing on the right of the screen, which pushes the page content over to the left, as a very realistic possibility. As James Forrester observes, being able to move dialogs depends on your screen size, and does not necessarily allow the desired part(s) of the page to be viewed.

@zchrykng
Copy link

zchrykng commented Nov 5, 2018

Well... that phab thread is depressing.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants