-
Notifications
You must be signed in to change notification settings - Fork 144
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Twinkle should use OOUI #414
Comments
See #384 for some relevant discussion. |
Noted. My understanding of #384 is that, in essence, you had "We don't have any plans to move away from jQuery UI at the moment." It is okay if you want to close this issue now; however, alternatively, we can keep it open for when the issue of movability of dialogues is addressed in OOUI. Is there a Phab ticket opened for it? |
Let's keep it open; I'm not sure why the other issue was closed. The relevant Phabricator task is https://phabricator.wikimedia.org/T51969. Bartosz's suggestion of a split-screen interface is interesting; I can imagine a fixed panel appearing on the right of the screen, which pushes the page content over to the left, as a very realistic possibility. As James Forrester observes, being able to move dialogs depends on your screen size, and does not necessarily allow the desired part(s) of the page to be viewed. |
Well... that phab thread is depressing. |
See https://phabricator.wikimedia.org/T219604#5374960 and subsequent patches (e.g. https://gerrit.wikimedia.org/r/#/c/mediawiki/core/+/543736/) Rearranging deck chairs before wikimedia-gadgets#414/https://phabricator.wikimedia.org/T49145
Currently, Twinkle uses jQuery.tipsy and other similar modules that are considered deprecated by MediaWiki's ResourceLoader. It also uses jQuery UI to draw its menus.
Since everything in MediaWiki is moving in the direction of OOUI, so should Twinkle.
The text was updated successfully, but these errors were encountered: