Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Can't rollback from contributions with "Do not show page content below diffs" option enabled #913

Closed
Xi-Plus opened this issue Apr 7, 2020 · 0 comments · Fixed by #914
Closed

Can't rollback from contributions with "Do not show page content below diffs" option enabled #913

Xi-Plus opened this issue Apr 7, 2020 · 0 comments · Fixed by #914
Labels
bug Module: fluff

Comments

@Xi-Plus
Copy link
Contributor

Xi-Plus commented Apr 7, 2020

Step to reproduce:

  1. Enable "Do not show page content below diffs" in your Preferences.
  2. Rollback edits from contributions.

Related code:
https://github.com/azatoth/twinkle/blob/b0fab3cddeb61284a9dd136c6b149d47e80795a4/modules/twinklefluff.js#L90-L95

This is due to phab:T231744. mw.config.get('wgRevisionId') returns 0 when page content is unavailable (diffonly=1).

Suggestion:
Append &diffonly=0 in rollback links.
Amorymeltzer added a commit to Amorymeltzer/twinkle that referenced this issue Apr 7, 2020
@Amorymeltzer
fluff: Fix revert coming from contribs if diffonly is used
5f1a0c2 
Fixes wikimedia-gadgets#913, same basic issue as wikimedia-gadgets#627/wikimedia-gadgets#628: if a user has "Do not show page content below diffs" selected in Special:Preferences, wgRevisionId is set to 0 on diffs.  While wikimedia-gadgets#628 took care of that for the links on diff pages themselves, trying to rollback from a contribs page was left unfixed.  Those links load the diff page then `auto`matically revert, so will run into the same issue.  This essentialy reverts back to the check before 3e5ec5b (wikimedia-gadgets#561), albeit by using `mw.util.getParamValue` rather than the no-longer-existing `Morebits.queryString.get` (wikimedia-gadgets#725).
@Amorymeltzer Amorymeltzer mentioned this issue Apr 7, 2020
Merged
wiki-ST47 pushed a commit to wiki-ST47/twinkle that referenced this issue Sep 2, 2020
@Amorymeltzer @wiki-ST47
fluff: Fix revert coming from contribs if diffonly is used
5b5ecfb 
Fixes wikimedia-gadgets#913, same basic issue as wikimedia-gadgets#627/wikimedia-gadgets#628: if a user has "Do not show page content below diffs" selected in Special:Preferences, wgRevisionId is set to 0 on diffs.  While wikimedia-gadgets#628 took care of that for the links on diff pages themselves, trying to rollback from a contribs page was left unfixed.  Those links load the diff page then `auto`matically revert, so will run into the same issue.  This essentialy reverts back to the check before 3e5ec5b (wikimedia-gadgets#561), albeit by using `mw.util.getParamValue` rather than the no-longer-existing `Morebits.queryString.get` (wikimedia-gadgets#725).
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Module: fluff
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fluff: Fix revert coming from contribs if diffonly is used Amorymeltzer/twinkle
2 participants
@Amorymeltzer @Xi-Plus