morebits: Fix bug in getting new token #1143
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This should at least partially explain #1119. |
Closed
|
Ohhhhh! Can't believe I did that. I would've preferred |
Stems from af13dce/wikimedia-gadgets#1038. Looks like, since `Morebits.wiki.api.getToken` explicitly creates a new construct, `this` in `returnError`'s return ends up going global (`window`). Reported at WT:TW (https://en.wikipedia.org/w/index.php?oldid=982033312#%22Getting_token%22_and_what?)
Amorymeltzer
force-pushed
the
morebits-thistoken
branch
from
c2c3301
to
5a6b8b3
Compare
|
Fair; done. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Stems from af13dce/#1038. Looks like, since
Morebits.wiki.api.getTokenexplicitly creates a new construct,thisinreturnError's return ends up going global (window).Reported at WT:TW