fluff: Allow for a list of custom edit summaries #1283
Conversation
TheTVExpert
force-pushed
the
patch-12
branch
2 times, most recently
from
f153779
to
65b7b50
Compare
|
Haven't tested, but this sounds pretty good to me. I had the same idea in mind to resolve #980. Use of a It would be good to provide some some defaults in the |
|
@siddharthvp I've added some defaults for the |
There was a problem hiding this comment.
Nice! I've a few comments with a quick first pass. It's a new use of Morebits.simpleWindow for us, but it seems to work pretty nicely!
Regarding #980, we had a discussion there @siddharthvp about not stopping the event loop. I never played around too deeply, is that a concern here?
| @@ -69,6 +69,7 @@ Twinkle.defaultConfig = { | |||
| markRevertedPagesAsMinor: [ 'vand' ], | |||
| watchRevertedPages: [ 'agf', 'norm', 'vand', 'torev' ], | |||
| watchRevertedExpiry: 'yes', | |||
| customReversionSummaryList: [{value: 'Unsourced addition', label: 'Unsourced'}, {value: 'Unexplained removal of content', label: 'Removal of content'}, {value: 'Potential copyright violation', label: 'Copyright violation'}, {value: 'Disruptive editing', label: 'Disruptive editing'}], | |||
There was a problem hiding this comment.
Not sure about this. Would it make more sense to make this list be empty and allow users to provide it themselves, then offer a few options (such as these?) in addition to that list? Kind of like the other customizations (warn/tag/welcome templates). It'd be annoying if you want to remove one, but I think a dropdown would help with that (though see other comment).
There was a problem hiding this comment.
Agreed this looks a bit silly. Not so much agreed on the solution. I see that twinkleconfig is missing a "plainlist" data type that would have been the natural solution here. It might be worth adding that just for this usecase.
There was a problem hiding this comment.
We'd have to prepopulate it with something, no?
There was a problem hiding this comment.
There are two things to discuss here:
One is how to store the data. A plainlist would be nice, but I don't think customlist is a huge hindrance. The latter might make the display easier to parse for folks if there are multiple options. So maybe "sources: removed reliable sources" and "sources: needs reliable sources" or something. A plainlist does seem simpler given we just need one string of text.
The other is how to incorporate defaults, which I'm more concerned about. With this setup, if someone customizes the list, they are forever left out of any changes we make unless they hit "reset, view the default options, then re-add from memory what they wanted; that's not good. Instead we can do what is done elsewhere, namely include the basic uses in the module, and then add any items from customReversionSummaryList on top of that. The advantage of the former is that users could cull the defaults, though.
Amorymeltzer
added
Feature request
Module: config
Module: fluff
Module: twinkle
No I just meant that a prompt can't be easily swapped for a simpleWindow; it requires quite a bit of restructuring – which has been done here. |
|
@Amorymeltzer Done. |
NovemLinguae
added
the
stale
|
We are closing old PRs that haven't been worked on in a couple years. Please feel free to reopen if you plan to work on it. |
Per https://en.wikipedia.org/w/index.php?title=Wikipedia_talk:Twinkle&diff=997640771&oldid=997285448. Also partially helps #980.