warn: Fix bug in section insertion when non-L2 headings present #1308
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We were only counting L2 sections, so when there were non-L2 sections present, the section index would be wrong. Stems from introduction in wikimedia-gadgets#1084, closes wikimedia-gadgets#1307.
|
@Xi-Plus This is untested since I'm not really around atm, but I think this should do it? |
|
Seems to work, although there's still an issue should there be a subsection within the dated L2; not sure what to do about that. Probably depends a lot on how things are structured within the section(s), so probably not worth touching. For now, though, I'll go ahead with this. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We were only counting L2 sections, so when there were non-L2 sections present, the section index would be wrong. Stems from introduction in #1084, closes #1307.