warn: ability to hide linked article and reason #1604
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@siddharthvp. Hey there. I wrote some unit tests for what is basically a private method. Think it's OK to keep them in or should I remove them? I know unit tests for private methods are sometimes considered a code smell. |
|
@NovemLinguae I think it's perfectly ok. Modules don't really have any "public" methods so this is the only way we can unit-test anything. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1408
Fixes #1538
Related #1537
When warning a user with
uw-editsummary2, hides the "linked page" and "reason" text boxes.I also created infrastructure to easily mark other templates with
hideLinkedPageandhideReason, if we need to in the future.I also added unit tests. I changed some unit test configuration files so that in the future, if we want to unit test modules, it will be easier.
Also renamed a couple variables.