morebits: fix handling of hard errors #1651
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In #1179, support for new error formats were added and used by default. However, the error handling code still assumes the legacy errorformat, which passes details of the first
error
, while in the newer ones we have an arrayerrors
.Notes for testing:
On testwiki, add text "Trigger abuse filter warn" to any page (it triggers https://test.wikipedia.org/wiki/Special:AbuseFilter/256):
Without this patch, we get:
The TypeError prevents any failure handling callback from running (one of the reasons why the callback approach is sub-optimal and we should be using promises everywhere).