Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

twinkle: vector-2022: hovering should open menu #1676

Merged
merged 3 commits into from Jan 22, 2023

Conversation

NovemLinguae
Copy link
Member

Fix #1674

This has a side effect of also making the "More" menu stay open on hover in vector-2022. Not sure if this is desirable, or if we should change the CSS to target the TW menu only.

@github-actions github-actions bot added the Module: twinkle The twinkle.js global gadget file label Dec 14, 2022
@nardog
Copy link
Contributor

nardog commented Dec 14, 2022

I don't think Twinkle should alter the UX of what's not Twinkle. Given the size of Twinkle users, many would mistake it's part of the skin or the site CSS, and misunderstandings among users and developers would ensue.

We should change the CSS to target the TW menu only if we are to hard-code it at all, but I think it's better to make this CSS a gadget on its own, thus giving users more choice and consistency. We already have a number of gadgets for "bring back X" anyway.

@NovemLinguae
Copy link
Member Author

Patch updated to only target the TW menu.

@nardog
Copy link
Contributor

nardog commented Dec 14, 2022

Just #p-twinkle:hover > .vector-menu-content would do also.

@NovemLinguae
Copy link
Member Author

NovemLinguae commented Jan 21, 2023

Went to go merge this today after some conversation at WT:TWINKLE, but the patch is no longer working on testwiki. @nardog do you have time to take a look?

@NovemLinguae
Copy link
Member Author

OK, I got this working but this branch/PR needs a rebase. I've never gotten a GitHub PR to rebase successfully though. If anyone has any tricks let me know. For now am going to try the following and maybe some other stuff:

VS Code -> checkout master
VS Code -> pull
VS Code -> checkout the PR (the VS Code GitHub app names the branch pr/NovemLinguae/1676)
git rebase origin/mastrer
git push --force origin pr/NovemLinguae/1676

@NovemLinguae NovemLinguae merged commit 2957ca2 into wikimedia-gadgets:master Jan 22, 2023
earlt612 added a commit to earlt612/twinkle that referenced this pull request Apr 30, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Module: twinkle The twinkle.js global gadget file
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Vector 2022: Twinkle menu does not appear on hover
2 participants