ci: always run unit tests #1781
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fix wikimedia-gadgets#1778 It is cheap to run these, it would help detect breakage of the unit test suite quicker, and if we ever add integration tests or unit tests of additional modules, it would make sure these run for those.
mdaniels5757
added a commit
to mdaniels5757/twinkle-for-commons
that referenced
this pull request
Jun 13, 2023
* docs: update CONTRIBUTING.md (wikimedia-gadgets#1756) * docs: mention git branches, GitHub forks, manual testing * space * remove advice about squashing and merging. not needed imo * mention "fixes 123" trick for closing GitHub issues * xfd: fix "undefined" error in userspace log XfD CfDS edit summary (wikimedia-gadgets#1768) * build(deps-dev): bump eslint from 8.33.0 to 8.37.0 (wikimedia-gadgets#1766) Bumps [eslint](https://github.com/eslint/eslint) from 8.33.0 to 8.37.0. - [Release notes](https://github.com/eslint/eslint/releases) - [Changelog](https://github.com/eslint/eslint/blob/main/CHANGELOG.md) - [Commits](eslint/eslint@v8.33.0...v8.37.0) --- updated-dependencies: - dependency-name: eslint dependency-type: direct:development update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * tag: rename {{More footnotes}} to {{More footnotes needed}} (wikimedia-gadgets#1760) * warn: Add uw-translation (wikimedia-gadgets#1740) * block: fix extra period in {{uw-botuhblock}} edit summary (wikimedia-gadgets#1774) * fix edit summary for uw-wrongsummary (wikimedia-gadgets#1773) * Add welcome-copyright (wikimedia-gadgets#1758) * Update friendlywelcome.js Add welcome-copyright to the welcome module * Update friendlywelcome.js add comma * fix template parameters --------- Co-authored-by: NovemLinguae <novemlinguae@gmail.com> * build(deps-dev): bump eslint from 8.37.0 to 8.39.0 (wikimedia-gadgets#1772) Bumps [eslint](https://github.com/eslint/eslint) from 8.37.0 to 8.39.0. - [Release notes](https://github.com/eslint/eslint/releases) - [Changelog](https://github.com/eslint/eslint/blob/main/CHANGELOG.md) - [Commits](eslint/eslint@v8.37.0...v8.39.0) --- updated-dependencies: - dependency-name: eslint dependency-type: direct:development update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * protect: add generic ECP option to protection module (wikimedia-gadgets#1762) * warn: add uw-fringe 1-4 (wikimedia-gadgets#1742) * add uw-fringe1-4 * add commas * fix lint * Update twinklewarn.js del uw-fringe4 * Update twinklewarn.js rm stray comma * ci: always run unit tests (wikimedia-gadgets#1781) * bump jest from v27 to v29 (wikimedia-gadgets#1787) - bump jest from v27 to v29 - bump mock-mediawiki to v1.4.0 - install jest-environment-jsdom, needed for jest v29 to work - adjust snapshot test syntax a bit, to work with jest v29 * add dependency notes to DEVELOPER.md (wikimedia-gadgets#1777) * add dependency notes to DEVELOPER.md * add jest-environment-jsdom * Rename friendlyshared.js to friendlyshared-disabled.js * Rename friendlytag.js to friendlytag-disabled.js * Rename friendlytalkback.js to friendlytalkback-disabled.js * Rename twinklearv.js to twinklearv-disabled.js * Rename twinkleblock.js to twinkleblock-disabled.js * Delete friendlywelcome.js * Delete twinkledeprod.js * Delete twinkleprod.js * Rename twinkleprotect.js to twinkleprotect-disabled.js * Rename twinklewarn.js to twinklewarn-disabled.js * Rename twinklexfd.js to twinklexfd-disabled.js --------- Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: NovemLinguae <79697282+NovemLinguae@users.noreply.github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: anupvs77 <96761022+anupvs77@users.noreply.github.com> Co-authored-by: earlt612 <58372701+earlt612@users.noreply.github.com> Co-authored-by: Red-tailed hawk <124543517+Red-tailed-Hawk@users.noreply.github.com> Co-authored-by: NovemLinguae <novemlinguae@gmail.com> Co-authored-by: lomrjyo <58796067+lomrjyo@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #1778
It is cheap to run these, it would help detect breakage of the unit test suite quicker, and if we ever add integration tests or unit tests of additional modules, it would make sure these run for those.