Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tag: Fix removing tags for maintenance templates where |name= points to a redirect #1960

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

9382
Copy link

@9382 9382 commented Apr 15, 2024

For #1863/#1618

If a maintenance template had been moved but its |name= wasn't updated, the code would pick up every version of that template except for the current name (since obviously that won't appear in a linkshere for itself and it tries to use the |name= for its current name). This fixes that by ensuring that whatever page linkshere resolves to is also included in the templates it attempts to remove

Credit to #1618 for the solution, I just tested it to make sure it worked

(Testing) Fixes #1618

@NovemLinguae NovemLinguae linked an issue Apr 15, 2024 that may be closed by this pull request
@NovemLinguae
Copy link
Member

I can't get #1618 to link. Note to self: when merging this, manually close #1618.

@9382
Copy link
Author

9382 commented Apr 21, 2024

Managed to get it to link by editing my original comment to include some keywords

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

tag: Twinkle doesn't detect {{More footnotes needed}} tag: Twinkle doesn't detect {{Self-contradictory}}
2 participants