Reload Twinklefluff interface when diff view changes #407
Conversation
This patch will hook Twinklefluff initialization to the mw.hook responsible for pages containing a diff. Hooking is only done when the methods for diff pages are loaded. Now for example the RevisionSlider extension that fires that hook will re-initiate the Twinkle links added to the page when moving through the revisions. This should fix #360 The hook gets fired everytime a diff page loads / reloads. To avoid having the diff links twice the original method got re- factored and the part addressing diff pages reacts only to the hook now. Further modules that might need to be re-initiated by hook could be added in a follow up.
|
The diff is a bit ugly. But I separated what looked like stuff affecting diff pages from stuff affecting other pages in Twinklefluff. Just put it into own methods and then applied the hooking on the part ( I assume ) loaded for diff pages. |
|
poke |
|
Here's the diff with whitespace removed, makes it a bit easier to review: https://github.com/azatoth/twinkle/pull/407/files?diff=unified&w=1 I'm going to try to test this today. |
|
I want to get #511 merged first, since I think that will create some nasty conflicts, but once that's done I'll merge changes into this and throw it up on test.wiki; my initial tests looked good! |
|
@WMDE-Fisch Finally got around to this — I've dealt with the merge conflicts here — but as I can't commit to your branch, if you could commit the two suggestions I've made (one necessary, one cosmetic) this looks good to go AFAICT. |
Implementing suggestions by Amorymeltzer, Co-Authored-By: WMDE-Fisch <christoph.jauera@wikimedia.de>
Thanks for the suggestions, I haven't looked into this for some time now and do not really have the time to test this atm. But if you're confident that its working feel free to merge. |
Co-Authored-By: WMDE-Fisch <christoph.jauera@wikimedia.de>
Amorymeltzer
dismissed
atlight’s stale review
Committed changes solve the issue, seem to work
…iff content hidden Fixes wikimedia-gadgets#627. If a user has "Do not show page content below diffs" selected in Special:Preferences, `wgRevisionId` will be set to 0 on diffs, meaning no links would be shown on diffs. Comparing `wgRevisionId` to `wgDiffNewId` from wikimedia-gadgets#563 appears to be a holdover from some (local) attempts to handle merge conflicts between wikimedia-gadgets#511 and wikimedia-gadgets#407, when I initially had this structured differently, but that should now handled in the init, so this was excessive.
`fluff` is already processing diffs, so this saves `warn` from checking anything on diffs. Plus, this takes advantage of the already in-place handling of the revision slider hook (wikimedia-gadgets#407) so that these `extraParams` are also added to user talk links when the revision slider is updated.
This patch will hook Twinklefluff initialization to the mw.hook
responsible for pages containing a diff. Hooking is only done when
the methods for diff pages are loaded.
Now for example the RevisionSlider extension that fires that hook
will re-initiate the Twinkle links added to the page when moving
through the revisions.
This should fix #360
The hook gets fired everytime a diff page loads / reloads. To
avoid having the diff links twice the original method got re-
factored and the part addressing diff pages reacts only to the
hook now.
Further modules that might need to be re-initiated by hook
could be added in a follow up.