Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tag: Add untag functionality #485

Merged
merged 26 commits into from
May 15, 2019

Commits on Dec 9, 2018

  1. Configuration menu
    Copy the full SHA
    06ce9e0 View commit details
    Browse the repository at this point in the history

Commits on Dec 25, 2018

  1. Configuration menu
    Copy the full SHA
    4328ff7 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    f892f93 View commit details
    Browse the repository at this point in the history
  3. tag: fix issues with merge tags, fix lint errors, simplify callbacks.…

    …article.removeTag function
    siddharthvp committed Dec 25, 2018
    Configuration menu
    Copy the full SHA
    95eac79 View commit details
    Browse the repository at this point in the history
  4. Configuration menu
    Copy the full SHA
    27f484c View commit details
    Browse the repository at this point in the history

Commits on Dec 29, 2018

  1. tag: replace "Twinkle.tag." --> "params." where possible;

    handle the special case for {{globalize}} tag, minor
    code cleanup elsewhere
    siddharthvp committed Dec 29, 2018
    Configuration menu
    Copy the full SHA
    804cef8 View commit details
    Browse the repository at this point in the history

Commits on Jan 13, 2019

  1. tag: group even the existing tags into {{multiple issues}} when

    tagging. Also changed the code structure in Twinkle.tag.callbacks.article
    siddharthvp committed Jan 13, 2019
    Configuration menu
    Copy the full SHA
    caa078c View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    6211341 View commit details
    Browse the repository at this point in the history
  3. tag: minor fixes

    siddharthvp committed Jan 13, 2019
    Configuration menu
    Copy the full SHA
    6c70cf1 View commit details
    Browse the repository at this point in the history

Commits on Jan 16, 2019

  1. tag: some code cleanup

    siddharthvp committed Jan 16, 2019
    Configuration menu
    Copy the full SHA
    53b6fe3 View commit details
    Browse the repository at this point in the history
  2. tag: change removeTag structure to allow all

    removals to process simultaneously
    siddharthvp committed Jan 16, 2019
    Configuration menu
    Copy the full SHA
    2db7fc1 View commit details
    Browse the repository at this point in the history
  3. tag: allow removal of *any* tag, not just the

    ones listed in Twinkle, provided that the
    template has the correct |name= set
    siddharthvp committed Jan 16, 2019
    Configuration menu
    Copy the full SHA
    0a9e9ac View commit details
    Browse the repository at this point in the history
  4. tag: show arrow link to template page for file

    and redirect tags as well
    siddharthvp committed Jan 16, 2019
    Configuration menu
    Copy the full SHA
    db2b832 View commit details
    Browse the repository at this point in the history

Commits on Mar 25, 2019

  1. Configuration menu
    Copy the full SHA
    11151cf View commit details
    Browse the repository at this point in the history
  2. tag: fix errors

    siddharthvp committed Mar 25, 2019
    Configuration menu
    Copy the full SHA
    0834bde View commit details
    Browse the repository at this point in the history

Commits on Mar 29, 2019

  1. tag: bit of code cleanup

    siddharthvp committed Mar 29, 2019
    Configuration menu
    Copy the full SHA
    0ecedd0 View commit details
    Browse the repository at this point in the history

Commits on Mar 31, 2019

  1. Configuration menu
    Copy the full SHA
    86f0bf4 View commit details
    Browse the repository at this point in the history

Commits on Apr 6, 2019

  1. tag: more code cleanup

    siddharthvp committed Apr 6, 2019
    Configuration menu
    Copy the full SHA
    fce17d0 View commit details
    Browse the repository at this point in the history

Commits on Apr 16, 2019

  1. tag: loads of cleanup

    - Use single API call for getting list of redirects of multiple templates,
    simplifying the code a great deal. No more use of recursion. The max results
    limit of 500 won't be breached in any realistic situation.
    - Remove unneccessary condition checks.
    siddharthvp committed Apr 16, 2019
    Configuration menu
    Copy the full SHA
    da42dca View commit details
    Browse the repository at this point in the history
  2. tag: rename Twinkle.tag.untaggable

    to Twinkle.tag.canRemove
    - Also added missing "var"s (lint error)
    - Disallow untaggging on last diff
    - fix var-undef error
    siddharthvp committed Apr 16, 2019
    Configuration menu
    Copy the full SHA
    05d1162 View commit details
    Browse the repository at this point in the history

Commits on May 12, 2019

  1. tag: cleanups

    - rename identifiers for clarity
    -- removeFromParamsToRemove --> removeTags
    -- removeTag --> (now an anonymous function)
    -- generateAlreadyPresentTagsCheckboxes --> makeCheckboxesForAlreadyPresentTags
    -- params.toRemove --> params.tagsToRemove
    -- params.toRemain --> params.tagsToRemain
    - fix wording in menu hover tooltip, and other minor fixes from code review by Amory
    - remove a bit of indentation hell by using "if (! ...) return; do stuff;" rather than "if (...) {do stuff;}"
    siddharthvp committed May 12, 2019
    Configuration menu
    Copy the full SHA
    db1dfe2 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    8fc0440 View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    d599148 View commit details
    Browse the repository at this point in the history

Commits on May 14, 2019

  1. tag: fix merge function, move translationListPage into main callback,

    move multipleIssuesException to below article tags list, some comment changes,
    other minor fixes
    siddharthvp committed May 14, 2019
    Configuration menu
    Copy the full SHA
    f599d7b View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    a5d1a2a View commit details
    Browse the repository at this point in the history

Commits on May 15, 2019

  1. Configuration menu
    Copy the full SHA
    8c28e72 View commit details
    Browse the repository at this point in the history