-
Notifications
You must be signed in to change notification settings - Fork 143
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
tag: further improvements #487
tag: further improvements #487
Conversation
reduces the lines of code and makes it easier to maintain
d11da2a
to
f37863b
Compare
f37863b
to
456d05a
Compare
subgroups for better user experience
456d05a
to
e47385a
Compare
@siddharthvp This looks mostly fine from reading through the code, although I'll hold off on testing and doing a thorough review until the merge conflicts are dealt with. I'll probably be squashing them given things like the leftover |
Done. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Needs some changes to get working
@siddharthvp In addition to the |
6d8332a
to
de7c819
Compare
It's certainly different, but I really like the changes here! Smart and nifty, cleans things up real well, and should make it much easier to maintain 🏆 |
de7c819
to
e39dd99
Compare
Closes wikimedia-gadgets#624. {{R from alternative name}} has a div element, and the processing schema introduced in wikimedia-gadgets#487 dies on it
Twinkle.tag.callback.evaluate
, reducing the lines of code as well as making to easier to maintain. Now if you add subgroups to some tags, you no longer have to update anything in this function.