speedy/tag: Move histmerge from speedy to tag #536
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Amorymeltzer
added a commit
to Amorymeltzer/twinkle
that referenced
this pull request
Mar 10, 2019
{{db-nowcommons}} is a redirect to {{now commons}}, which is not a speedy tag, and is already covered in the tag module. Similar to wikimedia-gadgets#536.
Also added named parameter vis a vis wikimedia-gadgets#441
This was referenced Mar 10, 2019
{{db-histmerge}} was [renamed](https://en.wikipedia.org/w/index.php?title=Template:History_merge&diff=420055188&oldid=401464558) and [removed](https://en.wikipedia.org/w/index.php?title=Wikipedia%3ACriteria_for_speedy_deletion&diff=prev&oldid=420062064) from the the CSD criteria in March, 2011, following [brief discussion](https://en.wikipedia.org/wiki/Wikipedia_talk:Criteria_for_speedy_deletion/Archive_42#Remove_db-histmerge_from_CSD). Of interest, the initial import of Twinkle into GitHub happened merely a week earlier.
Both have remained thus for nearly eight years, so we've technically been wrong for quite some time. `{{history merge}}` is a bit of a weird beast, with a warning associated with it (`{{w-c&pmove}}`) like a speedy; that template is available in `twinklewarn`, and I don't think people expect the tag module to handle those, so I think we're fine not doing that here. Allows for multiple instances of the template, a la `{{merge from}}`.
Closes wikimedia-gadgets#293
Amorymeltzer
force-pushed
the
speedytag-histmerge
branch
from
9203e20
to
ccd4138
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
{{db-histmerge}} was renamed and removed from the the CSD criteria in March, 2011, following brief discussion. Of interest, the initial import of Twinkle into GitHub happened merely a week earlier.
Both have remained thus for nearly eight years, so we've technically been wrong for quite some time.
{{history merge}}is a bit of a weird beast, with a warning associated with it ({{w-c&pmove}}) like a speedy; that template is available intwinklewarn, and I don't think people expect the tag module to handle those, so I think we're fine not doing that here. Allows for multiple instances of the template, a la{{merge from}}.Closes #293