Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use server time rather than client time wherever possible #741

Merged
merged 3 commits into from
Jan 7, 2020
Merged

Use server time rather than client time wherever possible #741

merged 3 commits into from
Jan 7, 2020

Commits on Jan 7, 2020

  1. morebits: wiki.page: add getter function to retrieve timestamp of las… 

    …t load
    @siddharthvp
    siddharthvp committed Jan 7, 2020
    Configuration menu
    Copy the full SHA
    77242b9 View commit details
    Browse the repository at this point in the history

  2. Use server time rather than client time within load callbacks 

    Largely addresses wikimedia-gadgets#6. Per wikimedia-gadgets#6 (comment), the server time is available to us whenever we are in a `.load()` callback, via the starttimestamp attribute in load API output which is stored in Morebits.wiki.page as ctx.loadTime, publicly exposed via `.getLoadTime()`.
    @siddharthvp
    siddharthvp committed Jan 7, 2020
    Configuration menu
    Copy the full SHA
    19eb400 View commit details
    Browse the repository at this point in the history

  3. xfd: avoid client clock for RFD log page determination 

    The curtimestamp parameter is added to the API request while finding the target of the redirect, so that the server time is available while determining the log page.
    @siddharthvp
    siddharthvp committed Jan 7, 2020
    Configuration menu
    Copy the full SHA
    3e21765 View commit details
    Browse the repository at this point in the history