Update CheckIfDead to v1.8 #35
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
*Updated UA to use more modern Chrome browser *Added TOR support for onion URLs. *Full checks now directly check the destination URLs if the requested URLs redirect as the headers are not passed thru to the destination URL requests. *Added checks.
This test constantly fails on Travis but passes elsewhere.
Fix issues brought up by Code Sniffer
kaldari
reviewed
May 24, 2019
| @@ -373,14 +469,14 @@ protected function getCurlOptions( $url, $full = false ) { | |||
| // Emulate a web browser request but make it accept more than a web browser | |||
| $header = [ | |||
| // @codingStandardsIgnoreStart Line exceeds 100 characters | |||
| 'Accept: text/xml,application/xml,application/xhtml+xml,text/html;q=0.9,text/plain;q=0.8,image/png,*/*;q=0.5', | |||
| 'Accept: text/html,application/xhtml+xml,application/xml;q=0.9,image/webp,image/apng,*/*;q=0.8,application/signed-exchange;v=b3', | |||
There was a problem hiding this comment.
Although I'm not sure it matters, "image/apng" looks like a typo.
There was a problem hiding this comment.
This is what I copied out of Safari. I honestly don't think it matters that much but we can change it.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
*Updated UA to use more modern Chrome browser
*Added TOR support for onion URLs.
*Full checks now directly check the destination URLs if the requested URLs redirect as the headers are not passed thru to the destination URL requests.
*Added checks.