Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sample code for API:RecentChanges #60

Merged
merged 3 commits into from
Mar 4, 2019

Conversation

brendajerop
Copy link
Contributor

Sample code for API:RecentChanges module to get the three most recent changes with sizes and flags.

@Abhishekism9450
Copy link

@brendajerop Can you add the documentation for the same in README also.

@brendajerop brendajerop changed the title Get recent changes Sample code for API:RecentChanges Feb 27, 2019
@brendajerop
Copy link
Contributor Author

@Abhishekism9450 Ok. Thanks:)

Copy link
Member

@srish srish left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great! The code sample looks good to me. As @Abhishekism9450 points out add it in README :)

I would like to merge this code sample when your documentation is ready to go live on MediaWiki too. I will also take another look at your code sample then.

For reference you can take a look at the pages we've improved using the documentation template: https://phabricator.wikimedia.org/T198916

@brendajerop
Copy link
Contributor Author

@srish Thanks for your feedback! I've made the changes as requested and my documentation is ready to go live:)

@srish srish merged commit 127a4d8 into wikimedia:master Mar 4, 2019
@srish
Copy link
Member

srish commented Mar 4, 2019

This is ready: https://www.mediawiki.org/wiki/User:Jeropbrenda/Sandbox/API:RecentChanges :) I've made minor changes. You can move this to https://www.mediawiki.org/wiki/API:RecentChanges. When you publish your changes make sure to say in the comment: "updated as per the improving the action API documentation project". For reference check following page's history as it recently got updated: https://www.mediawiki.org/w/index.php?title=API:Move&action=history. Let me know if you've any trouble while doing so :)

@brendajerop brendajerop deleted the get_recent_changes branch May 10, 2019 07:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants