Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

APIDeletedrevs added #87

Merged
merged 1 commit into from
Mar 4, 2019
Merged

APIDeletedrevs added #87

merged 1 commit into from
Mar 4, 2019

Conversation

eisheeta
Copy link
Contributor

@eisheeta eisheeta commented Mar 4, 2019

  1. Modified readme.md file
  2. Modified modules.json file
  3. Added code for Deletedrevs API

Tests:

  1. Tested the API in sandbox as well as on Postman.
  2. Tested Python code on my system with Pycharm.

Observation:
Both provided the same result.

@srish srish merged commit 558313a into wikimedia:master Mar 4, 2019
@srish
Copy link
Member

srish commented Mar 4, 2019

Thanks @eisheeta for working on this! I've made some minor fixes in your code and documentation.. it would be great it you could take a look at them and understand what I've changed :)

You can move your documentation changes to main namespace on MediaWiki.org. When you update the API:Deletedrevs page, make sure to leave in a comment: "updated as per API documentation improvements project". Thanks!

@eisheeta
Copy link
Contributor Author

eisheeta commented Mar 5, 2019

Hello @srish
Thank you so much for your feedback! All the changes have been duly noted! :)
Sorry for the inconvenience with my previous pull request. I'll take care of it next time!

@srish
Copy link
Member

srish commented Mar 11, 2019

@eisheeta You can move https://www.mediawiki.org/wiki/User:Eisheeta/Sandbox/API:Deletedrevs this to main namespace on MediaWiki.org. Let me know if you've any questions about it :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants