SshCommand: add option to also connect to tools.db #59
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
samwilson
reviewed
Jul 14, 2023
Command/SshCommand.php
Outdated
| @@ -84,6 +90,7 @@ protected function execute(InputInterface $input, OutputInterface $output): int | |||
| $username = $input->getArgument('username'); | |||
| $service = $input->getOption('service'); | |||
| $bindAddress = $input->getOption('bind-address'); | |||
| $toolsDb = $input->hasOption('toolsdb'); | |||
There was a problem hiding this comment.
hasOption just reports whether the option exists, so is always true. If you set it to VALUE_NONE above, and then here use getOption it'll be a boolean.
There was a problem hiding this comment.
Thank you! Now I know how it works :) I made bind-address have VALUE_REQUIRED as that's what it should be. Hope it's okay to slip that into the same PR.
samwilson
reviewed
Jul 14, 2023
This is for convenience for apps that need a tools-db connection Make --bind-address require a value Also add .editorconfig
theresnotime
approved these changes
Jul 14, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is for convenience for apps that need a tools-db connection
Also add .editorconfig