Add loading loop to wait for mw.loader.using to be available #117
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is because the Resource Loader queue is first processed by the startup module, and it seems that we (sometimes only) get in too quickly and it's not ready. This is a bit of a hack. https://phabricator.wikimedia.org/T232460 Bug: T232460
samwilson
force-pushed
the
load-order-api-module
branch
from
7ac8359
to
cc8eacb
Compare
|
No longer required, as the cause of the error here has been fixed in MediaWiki. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is because the Resource Loader queue is first processed by
the startup module, and it seems that we (sometimes only) get in
too quickly and it's not ready. This is a bit of a hack.