build: Add 'grunt-replace' & ensure sans-serif fallback in components SVGs
#281
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ts SVGs Add `sans-serif` as font fallback to components overview and components SVGs as Sketch doesn't provide such option in it's export settings.
Volker-E
added a commit
that referenced
this pull request
Nov 9, 2019
Sketch has the bad attitude to put advertisment into SVG's `desc` tag. We got rid of it in 4def9c4#diff-35b4a816e0441e6a375cd925af50752cR309 with only circumventing the issue for the time being. Re-crushing the SVGs in this step.
Volker-E
added a commit
that referenced
this pull request
Nov 9, 2019
Sketch has got the bad attitude to spam SVG's `desc` tag with advertisment. We got rid of it in 4def9c4#diff-35b4a816e0441e6a375cd925af50752cR309 with only circumventing the issue for the time being. Re-crushing all the SVGs in this step.
Volker-E
added a commit
that referenced
this pull request
Nov 9, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add
sans-serifas font fallback to components overview and componentsSVGs as Sketch doesn't provide such option in it's export settings.