This repository has been archived by the owner on May 15, 2024. It is now read-only.
Added a target property #354
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I discovered when the "Contribute on GitHub button is clicked, it just loads closing up the file the individual was actually reading which is not suppose to be. I added a target property so it opens up a new tab whenever it is clicked, in that case the user can still continue what he/she was doing previously before clicking the button so he/she does not loose track of where he/she was.
Volker-E
suggested changes
Mar 11, 2020
|
Can I work on implementing it on all pages? |
|
@olawanlejoel For sure, happily do so! Please make sure, that you also add |
|
Thanks @Volker-E. |
|
@Volker-E , I just implemented the |
|
I have reviewed and i think that should be all the pages that require this changes |
Volker-E
approved these changes
Apr 1, 2020
|
Thanks @olawanlejoel! |
|
I'm happy it got merged. Won't it be cool if we have the github logo in
front of the "contribute to github" link?
…On Wed, Apr 1, 2020, 11:22 PM Volker E. ***@***.***> wrote:
Thanks @olawanlejoel <https://github.com/olawanlejoel>!
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#354 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/ANXRMIXB25PXHNBFSATIYD3RKO5BPANCNFSM4LF5KN7A>
.
|
|
We've decided against it for design and branding reasons. We wanted to emphasize the Wikimedia branding while providing an easy discoverable GitHub link. |
|
Oh, thanks for the information. It was really fun contributing to
WikipediaUI-style-Guide.
Thanks.
…On Thu, Apr 2, 2020, 12:22 AM Volker E. ***@***.***> wrote:
We've decided against it for design and branding reasons. We wanted to
emphasize the Wikimedia branding while providing an easy discoverable
GitHub link.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#354 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/ANXRMIXCDHR4GROK3U37KYLRKPECVANCNFSM4LF5KN7A>
.
|
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I discovered when the "Contribute on GitHub" button is clicked, it just loads closing up the file the individual was actually reading which is not suppose to be. I added a target property so it opens up a new tab whenever it is clicked, in that case the user can still continue what he/she was doing previously before clicking the button so he/she does not loose track of where he/she was.