Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove $that = $this #224

Open
reedy opened this issue Nov 24, 2021 · 3 comments
Open

Remove $that = $this #224

reedy opened this issue Nov 24, 2021 · 3 comments

Comments

@reedy
Copy link
Member

reedy commented Nov 24, 2021

I don't believe that is needed anymore...

@himanshu007-creator
Copy link

Hi, i would like to work on this issue

@valerio-bozzolan
Copy link

I didn't understand what this issue is about

Abhishektharu added a commit to Abhishektharu/composer-merge-plugin that referenced this issue Oct 18, 2023
@mcaskill
Copy link
Contributor

mcaskill commented Jan 13, 2024

I assume the issue is about the ambiguity of the variable's name $that in MergePluginTest.

For example, $test would better reflect its reference.

Ideally, I think the anonymous functions are already bound to the test controller so there's no need to pass the test to the functions.

When declared in the context of a class, the current class is automatically bound to it, making $this available inside of the function's scope.

Anonymous functions, PHP.net

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

No branches or pull requests

4 participants