New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add source reference information for merged packages #103
Conversation
Real good work @webflo, seems to work very well, this is my composer.json:
And this was the result:
|
} | ||
$references = $this->extractReferences($links, $references); | ||
} | ||
$root->setReferences($references); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@bd808 setReferences is not part of the RootPackageInteface
. Should we use unwrapIfNeeded
or should we try to fix it upstream?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'd say that both are wanted. At the very least unwrapIfNeeded
will cast or provide access to the aliased RootPackage
. Upstreaming interface additions and tests is always a good idea I think. See composer/composer@06c44ce for an example of us doing this previously.
Commits should be squashed and rebased on current master. |
FWIW, The patch looks great to me! |
Attempt to fix #101