Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Introduce language suggester for monolingual #112

Merged
merged 4 commits into from
Sep 4, 2014
Merged

Conversation

thiemowmde
Copy link
Contributor

This is an alternative implementation of #93.

Please note that this patch is only a first step. Some code should be moved from ExpertExtender.LanguageSelector.js to this new file. But I don't want to make this to complicated. More refactoring can easily be done after this is reviewed and merged.

Questions:

  • I'm not sure what the current best naming practice is. I modeled suggestLanguage after suggestCommons.
  • It's probably better to use data objects instead of strings, similar to pagesuggester for example.

Bug: 67395

snaterlicious added a commit that referenced this pull request Sep 4, 2014
Introduce language suggester for monolingual
@snaterlicious snaterlicious merged commit 2e4e7cb into master Sep 4, 2014
@snaterlicious snaterlicious deleted the suggestLanguage branch September 4, 2014 09:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
2 participants