Pass router into eventgate factory function #7
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This will allow for custom EventGate implementations (like eventgate-wikimedia) to register extra routes with the eventgate service. eventgate-wikimedia will use this to expose runtime stream configs. Bug: T253157 Change-Id: I72b21df3696e5fa09bf5e9597037c80af79ce6d6
Change-Id: Id35ef1a18d476bf276de7ac9db8ba18a28d31c75
Pchelolo
approved these changes
May 26, 2020
|
eventgate-wikimedia's use of this is at https://gerrit.wikimedia.org/r/c/eventgate-wikimedia/+/597341 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This will allow for custom EventGate implementations
(like eventgate-wikimedia) to register extra routes
with the eventgate service.
eventgate-wikimedia will use this to expose runtime stream
configs.
Bug: T253157
Change-Id: I72b21df3696e5fa09bf5e9597037c80af79ce6d6