Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve logging in EventProcessor, using Stopwatch to log runtimes #216

Merged
merged 1 commit into from
Mar 12, 2019

Conversation

MusikAnimal
Copy link
Member

@MusikAnimal MusikAnimal commented Mar 8, 2019

When events are processed via the UI ('Update Data' button), the output
is logged var/logs/event_processor.log. When running an update directly
via 'php bin/console app:process-event', colourized output is sent to
stdout.

This doesn't include actual query runtimes, as requested by T205322, but
it does reveal which pieces of the update process are the slowest.

Bug: T205322

When events are processed via the UI ('Update Data' button), the output
is logged var/logs/event_processor.log. When running an update directly
via 'php bin/console app:process-event', colourized output is sent to
stdout.

This doesn't include actual query runtimes, as requested by T205322, but
it does reveal which pieces of the update process are the slowest.

Bug: T205322
@MusikAnimal MusikAnimal added the Ready for review Ready for peer review label Mar 8, 2019
Copy link
Member

@samwilson samwilson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works in my testing!

I dunno if we need to round milliseconds to two decimal places. But all good. :)

@MusikAnimal
Copy link
Member Author

I dunno if we need to round milliseconds to two decimal places. But all good. :)

Ha! You are correct. I could have sworn this was seconds. I'll change that later

@MusikAnimal MusikAnimal merged commit 7d0d981 into master Mar 12, 2019
@MusikAnimal MusikAnimal deleted the event-processor-profiling branch March 12, 2019 16:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Ready for review Ready for peer review
2 participants