Reorganise the metadata part at the top of the event page #228
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Move existing items (dates and wiki list) around, and add new category list. Both lists are now formatted with a new 'list_format' Twig filter which uses Intuition's built-in list method. Bug: T218340
samwilson
force-pushed
the
event-ui-refactor-T218340
branch
from
57a4c24
to
010f5dc
Compare
|
The commit looks good, however I have a question about the spec, asked it in the bug itself. |
|
Surely this isn't the intended appearance? It also looks odd to have "Category:" when there are none.
|
|
I think it should have a dash. I've asked on the ticket for clarification. This whole patch wasn't actually required it turns out. Oops. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Move existing items (dates and wiki list) around, and add new
category list. Both lists are now formatted with a new
'list_format' Twig filter which uses Intuition's built-in
list method.
Bug: T218340