Remove String.prototype overriding #166
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It was a wrong design. String.locale and String.prototype.toLocaleString removed
jdforrester
reviewed
Jul 19, 2018
package.json
Outdated
| @@ -26,7 +26,7 @@ | |||
| "grunt-contrib-connect": "1.0.1", | |||
| "grunt-contrib-qunit": "1.2.0", | |||
| "grunt-contrib-watch": "1.0.0", | |||
| "eslint-config-wikimedia": "0.3.0", | |||
| "eslint-config-wikimedia": "0.6.0", | |||
There was a problem hiding this comment.
If you're updating this, you need to update .eslintrc.json too.
Should go with eslint-config-wikimedia 0.6.0
jdforrester
approved these changes
Jul 19, 2018
Krinkle
approved these changes
Jul 19, 2018
|
Seems to pass without update to eslintrc, but it did indeed require a grunt-eslint bump. I'll land this now (given it passes), and improve further in #144 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It was a wrong design.
String.locale and String.prototype.toLocaleString removed