While using data-i18n key method, when choosing back to english, messages were not updating. #20
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Jishnu, why this was closed? is it relevant to apply? |
|
It is relevant because, if key and translated string are same it was not applying. Closed because build was failing. eg. key is "hello and English string is "hello", when selecting back to english from some other language, string was not updating because key and message are same. |
|
The build failure log is available at https://travis-ci.org/wikimedia/jquery.i18n/builds/3629048. Do you want to try fixing the tests? You can test the build locally using grunt. Let me know if you need any help. |
Conflicts: src/jquery.i18n.js
|
thanks jishnu |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit will fix this issue.