Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support for explicit 0= and 1= forms #24

Merged
merged 2 commits into from Jul 23, 2013
Merged

Conversation

darkyen
Copy link
Contributor

@darkyen darkyen commented Jan 18, 2013

Adds support for explicit 0= and 1= forms in javascript , PHP has the same https://gerrit.wikimedia.org/r/#/c/23943/

Adds support for explicit 0= and 1= forms in javascript , PHP has the same https://gerrit.wikimedia.org/r/#/c/23943/
@santhoshtr
Copy link
Member

Please add qunit test cases for this

…tter can traverse unexpectedly over Array.prototype's enumarable methods
@@ -0,0 +1,2681 @@
/**
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This file need not be added

@santhoshtr
Copy link
Member

Make sure that all grunt checks pass this tests

@darkyen
Copy link
Contributor Author

darkyen commented Jan 23, 2013

Grunt Passed all checks for me! , Dunno why it added the dist folder though.

@santhoshtr
Copy link
Member

Ping

@santhoshtr
Copy link
Member

I completed this in pull request #39

@amire80 amire80 merged commit c5de3dc into wikimedia:master Jul 23, 2013
Nikerabbit pushed a commit to Nikerabbit/jquery.i18n that referenced this pull request Dec 29, 2014
Nikerabbit pushed a commit to Nikerabbit/jquery.i18n that referenced this pull request Dec 29, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants