Changed extended patterns to concatenation #469
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This changes the behavior of the dependency loading, as it was earlier an override, and with this change it is an extension (or a concatenation).
During testing it became obvious that the previous solution simply did not work. Perhaps I did something obviously wrong, but I did check with other code. I even had to redo some of my own code that was obviously wrong.
I have not been able to verify if this change fails somewhere, it is only verified on a Ubu-box in Vagrant, and other OS and setup might handle the altGr-key somewhat different. During tests on that setup I only get errors from the usual suspects, no new errors. Still I am not convinced that the testing framework accurately reproduce a real browser when it comes to key events.
This change set replaces the somewhat messy #466.