Small improvements in my-xkb layout #652
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1. Add comments with explicit characters for easier understanding of the rules code. 2. Remove the whole patterns_x section, which is just outputting the same characters that would be shown if the input method is disabled. 3. Remove some rules that output the same characters. 4. Add some tests, and add test names. I verified these with the xkb keyboard on Ubuntu.
santhoshtr
approved these changes
Nov 12, 2021
bennylin
pushed a commit
to bennylin/jquery.ime
that referenced
this pull request
Apr 2, 2023
1. Add comments with explicit characters for easier understanding of the rules code. 2. Remove the whole patterns_x section, which is just outputting the same characters that would be shown if the input method is disabled. 3. Remove some rules that output the same characters. 4. Add some tests, and add test names. I verified these with the xkb keyboard on Ubuntu. Co-authored-by: Santhosh Thottingal <santhosh.thottingal@gmail.com>
bennylin
pushed a commit
to bennylin/jquery.ime
that referenced
this pull request
Jul 10, 2023
1. Add comments with explicit characters for easier understanding of the rules code. 2. Remove the whole patterns_x section, which is just outputting the same characters that would be shown if the input method is disabled. 3. Remove some rules that output the same characters. 4. Add some tests, and add test names. I verified these with the xkb keyboard on Ubuntu. Co-authored-by: Santhosh Thottingal <santhosh.thottingal@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
for easier understanding of the rules code.
just outputting the same characters that would
be shown if the input method is disabled.
I verified these with the xkb keyboard on Ubuntu.