Fix deprecation notices with PHP 8.2.

[sebastic]

Dynamic properties are deprecated in 8.2, see: https://wiki.php.net/rfc/deprecate_dynamic_properties

[glo71317]

Guys any plan to merge this PR and also i can see some more depreciation related PHP 8.2

[Krinkle]

I'm not able to reproduce or find how or where this is read or written to. I don't see it in the composer test output on PHP 8.2, and quick analysis doesn't show an obvious place where Color->name takes place.

$ git grep -E '>name =|\bname;' lib/
lib/Less/Parser.php:                if ( $rule->name == $var_name ) {
lib/Less/Parser.php:                    $name = $nameLoop = $val->name;
lib/Less/Parser.php:        $nonVendorSpecificName = $name;
lib/Less/Parser.php:            return $name;
lib/Less/Tree/Call.php: public $name;
lib/Less/Tree/Call.php:     $this->name = $name;
lib/Less/Tree/Directive.php:    public $name;
lib/Less/Tree/Directive.php:        $this->name = $name;
lib/Less/Tree/Mixin/Definition.php: public $name;
lib/Less/Tree/Mixin/Definition.php:     $this->name = $name;
lib/Less/Tree/NameValue.php:    public $name;
lib/Less/Tree/NameValue.php:        $this->name = $name;
lib/Less/Tree/Rule.php: public $name;
lib/Less/Tree/Rule.php:     $this->name = $name;
lib/Less/Tree/Rule.php:     $name = $this->name;
lib/Less/Tree/Rule.php:             $this->name = $name;
lib/Less/Tree/Variable.php: public $name;
lib/Less/Tree/Variable.php:     $this->name = $name;
lib/Less/Tree/Variable.php:         $name = $this->name;
lib/Less/Visitor/toCSS.php:     if ( $directiveNode->name === '@charset' ) {
lib/Less/Visitor/toCSS.php:             $key = $rule->name;

The only one that seems plausible is the references in toCSS.php, but those have explicit Rule or NameValue type checks which each have a name property already.

Do you have a stack trace or reproduction case for this one?

[sebastic]

<b>Deprecated</b>:  Creation of dynamic property Less_Tree_Color::$name is deprecated in <b>/usr/share/php/Icinga/Less/Visitor.php</b> on line <b>196</b><br />

See: https://github.com/Icinga/icingaweb2/blob/v2.11.3/library/Icinga/Less/Visitor.php#L196

[Krinkle]

I'll land this without the Color change for now.