Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Cache all symbols #5

Merged
merged 1 commit into from Aug 23, 2022
Merged

Cache all symbols #5

merged 1 commit into from Aug 23, 2022

Conversation

adamwight
Copy link
Collaborator

Drops the code path for reading files at runtime.

thiemowmde
thiemowmde approved these changes Aug 23, 2022
View reviewed changes
Copy link
Collaborator

@thiemowmde thiemowmde left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have not manually tested this but the code looks great. Love it! I can confirm the removal of the duplicate code path.

lib/cache.js Show resolved Hide resolved
@adamwight adamwight force-pushed the cache-all branch 2 times, most recently from 69cdb0f to 85f262e Compare August 23, 2022 11:41
@adamwight
Copy link
Collaborator Author

Thanks for mentioning the additional unused code, I've removed that now!

@adamwight
Cache all symbols
d3c810c 
Drops the code path for reading files at runtime.
Base automatically changed from refactor-color to master August 23, 2022 13:20
@thiemowmde thiemowmde merged commit d35b720 into master Aug 23, 2022
@thiemowmde thiemowmde deleted the cache-all branch August 23, 2022 13:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@thiemowmde thiemowmde thiemowmde approved these changes

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
2 participants
@adamwight @thiemowmde