Capitalized bullet points and fixed type #10
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…instead of WikiMedia
|
I believe that last sentence IS in fact supposed to refer to Wikimedia, as in the Wikimedia Foundation. Wikimedia is the movement behind Wikipedia, Wiktionary, and Wikimedia Commons (among others), whereas MediaWiki is the software on which these services run. Just my two cents. |
|
You're right about the definitions of each 'wiki' term, but I think it was intentionally supposed to mean actual specifically Wikimedia regulars. |
|
Also the lack of capitals in the bullet list is grammatically correct. Not really that big of a deal. |
wmfgerrit
pushed a commit
that referenced
this pull request
Jan 25, 2016
Right now it is possible to emit a raw \n or \r to the UDP feed by encoding it as an HTML entity, e.g. This could be used for arbitrary IRC command execution in bots which do not subsequently perform their own escaping. This commit changes it so that entities are decoded first before \n and \r are stripped. Change-Id: I3f7005abded3fbafb586754d763a00a4018f0954
wmfgerrit
pushed a commit
that referenced
this pull request
May 20, 2016
SVG filter incorrectly used the m modifier when checking if an href
attribute started with 'https?://', incorrectly matching attributes
such as, "javascript:alert(' http://foo')".
Bug: T122653
Change-Id: I41291fff344241cad3171f3e8050de99b62a2296
Signed-off-by: Chad Horohoe <chadh@wikimedia.org>
wmfgerrit
pushed a commit
that referenced
this pull request
May 20, 2016
SVG filter incorrectly used the m modifier when checking if an href
attribute started with 'https?://', incorrectly matching attributes
such as, "javascript:alert(' http://foo')".
Bug: T122653
Change-Id: I41291fff344241cad3171f3e8050de99b62a2296
Signed-off-by: Chad Horohoe <chadh@wikimedia.org>
wmfgerrit
pushed a commit
that referenced
this pull request
May 20, 2016
SVG filter incorrectly used the m modifier when checking if an href
attribute started with 'https?://', incorrectly matching attributes
such as, "javascript:alert(' http://foo')".
Bug: T122653
Change-Id: I41291fff344241cad3171f3e8050de99b62a2296
Signed-off-by: Chad Horohoe <chadh@wikimedia.org>
wmfgerrit
pushed a commit
that referenced
this pull request
May 20, 2016
SVG filter incorrectly used the m modifier when checking if an href
attribute started with 'https?://', incorrectly matching attributes
such as, "javascript:alert(' http://foo')".
Bug: T122653
Change-Id: I41291fff344241cad3171f3e8050de99b62a2296
Signed-off-by: Chad Horohoe <chadh@wikimedia.org>
wmfgerrit
pushed a commit
that referenced
this pull request
May 20, 2016
SVG filter incorrectly used the m modifier when checking if an href
attribute started with 'https?://', incorrectly matching attributes
such as, "javascript:alert(' http://foo')".
Bug: T122653
Change-Id: I41291fff344241cad3171f3e8050de99b62a2296
Signed-off-by: Chad Horohoe <chadh@wikimedia.org>
wmfgerrit
pushed a commit
that referenced
this pull request
Oct 13, 2018
…thods" This reverts commit b416e16. Fails on Travis CI / PHP 7.1 / Postgres: > Creating administrator user account > > UnexpectedValueException: > Got connection to 'traviswiki-mediawiki', but expected 'traviswiki'. > > Backtrace: > #0 includes/libs/rdbms/loadbalancer/LoadBalancer.php(887): Wikimedia\Rdbms\LoadBalancer->openForeignConnection(integer, string, integer) > #1 includes/libs/rdbms/loadbalancer/LoadBalancer.php(766): Wikimedia\Rdbms\LoadBalancer->openConnection(integer, string, integer) > #2 includes/libs/rdbms/loadbalancer/LoadBalancer.php(851): Wikimedia\Rdbms\LoadBalancer->getConnection(integer, array, string, integer) > #3 includes/jobqueue/JobQueueDB.php(780): Wikimedia\Rdbms\LoadBalancer->getConnectionRef(integer, array, string, integer) > #4 includes/jobqueue/JobQueueDB.php(761): JobQueueDB->getDB(integer) > #5 includes/jobqueue/JobQueueDB.php(187): JobQueueDB->getMasterDB() > #6 includes/jobqueue/JobQueue.php(332): JobQueueDB->doBatchPush(array, integer) > #7 includes/jobqueue/JobQueue.php(302): JobQueue->batchPush(array, integer) > #8 includes/jobqueue/JobQueueGroup.php(154): JobQueue->push(array) > #9 includes/user/UserGroupMembership.php(162): JobQueueGroup->push(array) > #10 includes/user/User.php(3733): UserGroupMembership->insert(boolean) > #11 includes/installer/Installer.php(1680): User->addGroup(string) > #12 includes/installer/Installer.php(1601): Installer->createSysop(PostgresInstaller) > #13 includes/installer/CliInstaller.php(176): Installer->performInstallation(array, array) Change-Id: I269df89d47cc5a183af630447cd1642d3d4a3deb
wmfgerrit
pushed a commit
that referenced
this pull request
Apr 7, 2019
PhanTypeExpectedObjectPropAccess was flagged by phan in the DatabaseMysqli and Preprocessor_Hash classes. In Database, the $conn property might be a standard object, such as `\mysqli`, which is not a resource. In Preprocessor, phan was getting confused and thinking PPDStack::getCurrentPart() was returning bool, and not a PPDPart object. Adding explicit documentation about the return value fixed that. Change-Id: I0a3aa219693da5cb46ff9c0936841ed740c6968a
wmfgerrit
pushed a commit
that referenced
this pull request
Apr 7, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Capitalized first bullet sets and updated last sentence to say MediaWiki instead of WikiMedia