Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Move talk page notification data from 'user-menu' to 'notifications'
**Note**: This change will affect the order of the yellow talk page message notification on legacy Vector/other skins by moving it from after the `#pt-notifications-notice` element to before the `#pt-notifications-alert` element. This was done because the notification is related to the list of messages that appear when the bell icon is clicked so having it in close proximity to that icon is hopefully more intuitive than having it next to the unrelated inbox icon. [1] Per T274428, we need this notification to be inside the `notifications` array instead of inside the `user-menu` array. Additionally: * Per T274428, update the notifications message copy to "You have a new Talk page message" * Remove the `onPersonalUrls` hook method inside EchoHooks, unregister its use as a hook in extension.json, and update its references in Echo. [1] T274428#7113896 Bug: T274428 Change-Id: I5ae0ec089bcf0eec1ec7ac13f60e811f54e1d8e1
- Loading branch information
1 parent
12e3d5a
commit 3a351cf
Showing
4 changed files
with
18 additions
and
26 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters