Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Bug: T244826 Depends-On: If4f67a6fa0e26ade3fc0420e62fa836c2a3e4b2e Depends-On: I197366ef6f490bb7676c21d99568e4ffd229673b Change-Id: Ibd136521f963a71a8a21c861f0294f2b3b7d35eb
- Loading branch information
Showing
14 changed files
with
1,355 additions
and
194 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -8,3 +8,4 @@ | |
| .idea/ | ||
| .vscode/ | ||
| .eslintcache | ||
| .api-testing.config.json | ||
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,2 @@ | ||
| recursive: true | ||
| timeout: 0 |
This file was deleted.
Oops, something went wrong.
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,150 @@ | ||
| <?php | ||
|
|
||
| namespace MediaWiki\Extension\EventBus; | ||
|
|
||
| use EventBus; | ||
| use EventFactory; | ||
| use Exception; | ||
| use Job; | ||
| use MediaWiki\Rest\HttpException; | ||
| use MediaWiki\Rest\RequestInterface; | ||
| use MediaWiki\Rest\Validator\BodyValidator; | ||
| use Psr\Log\LoggerInterface; | ||
|
|
||
| /** | ||
| * Class EventBodyValidator | ||
| * | ||
| * Validates the body | ||
| */ | ||
| class EventBodyValidator implements BodyValidator { | ||
|
|
||
| /** | ||
| * @var string | ||
| */ | ||
| private $secretKey; | ||
|
|
||
| /** | ||
| * @var LoggerInterface | ||
| */ | ||
| private $logger; | ||
|
|
||
| public function __construct( $secretKey, LoggerInterface $logger ) { | ||
| $this->secretKey = $secretKey; | ||
| $this->logger = $logger; | ||
| } | ||
|
|
||
| /** | ||
| * @param RequestInterface $request | ||
| * @return Job|mixed|void | ||
| * @throws HttpException | ||
| */ | ||
| public function validateBody( RequestInterface $request ) { | ||
| // get the info contained in the body | ||
| $event = null; | ||
| try { | ||
| $event = json_decode( $request->getBody()->getContents(), true ); | ||
| } catch ( Exception $e ) { | ||
| throw new HttpException( "Could not decode the event", 500, [ | ||
| 'error' => $e->getMessage(), | ||
| ] ); | ||
| } | ||
|
|
||
| // check that we have the needed components of the event | ||
| if ( !isset( $event['database'] ) || | ||
| !isset( $event['type'] ) || | ||
| !isset( $event['params'] ) | ||
| ) { | ||
| $missingParams = []; | ||
| if ( !isset( $event['database'] ) ) { $missingParams[] = 'database'; | ||
| } | ||
| if ( !isset( $event['type'] ) ) { $missingParams[] = 'type'; | ||
| } | ||
| if ( !isset( $event['params'] ) ) { $missingParams[] = 'params'; | ||
| } | ||
| throw new HttpException( 'Invalid event received', 400, [ 'missing_params' => $missingParams ] ); | ||
| } | ||
|
|
||
| if ( !isset( $event['mediawiki_signature'] ) ) { | ||
| throw new HttpException( 'Missing mediawiki signature', 403 ); | ||
| } | ||
|
|
||
| $signature = $event['mediawiki_signature']; | ||
| unset( $event['mediawiki_signature'] ); | ||
|
|
||
| $serialized_event = EventBus::serializeEvents( $event ); | ||
| $expected_signature = EventFactory::getEventSignature( | ||
| $serialized_event, | ||
| $this->secretKey | ||
| ); | ||
|
|
||
| $verified = is_string( $signature ) | ||
| && hash_equals( $expected_signature, $signature ); | ||
|
|
||
| if ( !$verified ) { | ||
| throw new HttpException( 'Invalid mediawiki signature', 403 ); | ||
| } | ||
|
|
||
| // check if there are any base64-encoded parameters and if so decode them | ||
| foreach ( $event['params'] as $key => &$value ) { | ||
| if ( !is_string( $value ) ) { | ||
| continue; | ||
| } | ||
| if ( preg_match( '/^data:application\/octet-stream;base64,([\s\S]+)$/', $value, $match ) ) { | ||
| $value = base64_decode( $match[1], true ); | ||
| if ( $value === false ) { | ||
|
|
||
| throw new HttpException( | ||
| 'Internal Server Error', | ||
| 500, | ||
| "base64_decode() failed for parameter {$key} ({$match[1]})" ); | ||
| } | ||
| } | ||
| } | ||
| unset( $value ); | ||
|
|
||
| return $this->getJobFromParams( $event ); | ||
| } | ||
|
|
||
| /** | ||
| * @param array $jobEvent containing the job EventBus event | ||
| * @return Job|void | ||
| * @throws HttpException | ||
| */ | ||
| private function getJobFromParams( array $jobEvent ) { | ||
| try { | ||
| $job = Job::factory( $jobEvent['type'], $jobEvent['params'] ); | ||
| } catch ( Exception $e ) { | ||
| return $this->throwJobErrors( [ | ||
| 'status' => false, | ||
| 'error' => $e->getMessage(), | ||
| 'type' => $jobEvent['type'] | ||
| ] ); | ||
| } | ||
|
|
||
| if ( $job === null ) { | ||
| return $this->throwJobErrors( [ | ||
| 'status' => false, | ||
| 'error' => 'Could not create a job from event', | ||
| 'type' => $jobEvent['type'] | ||
| ] ); | ||
| } | ||
|
|
||
| return $job; | ||
| } | ||
|
|
||
| /** | ||
| * @param array $jobResults | ||
| * @throws HttpException | ||
| */ | ||
| private function throwJobErrors( $jobResults ) { | ||
| $this->logger->error( 'Failed creating job from description', [ | ||
| 'job_type' => $jobResults['type'], | ||
| 'error' => $jobResults['error'] | ||
| ] ); | ||
|
|
||
| throw new HttpException( "Failed creating job from description", | ||
| 400, | ||
| [ 'error' => $jobResults['error'] ] | ||
| ); | ||
| } | ||
| } |
Oops, something went wrong.