build: Updating mediawiki/mediawiki-codesniffer to 28.0.0

The following sniffs are failing and were disabled: * PSR12.Properties.ConstantVisibility.NotFound Change-Id: If22e1d6f7fa1b93320273e827b656362fd061c14
wikimedia · Oct 21, 2019 · d7df0f9 · d7df0f9
1 parent e461549
commit d7df0f9
Show file tree

Hide file tree

Showing 5 changed files with 6 additions and 5 deletions.
diff --git a/.phpcs.xml b/.phpcs.xml
@@ -15,6 +15,7 @@
 		<exclude name="MediaWiki.Usage.DeprecatedGlobalVariables.Deprecated$wgTitle" />
 		<exclude name="MediaWiki.Usage.ForbiddenFunctions.passthru" />
 		<exclude name="MediaWiki.WhiteSpace.SpaceBeforeSingleLineComment.NewLineComment" />
+		<exclude name="PSR12.Properties.ConstantVisibility.NotFound" />
 	</rule>
 	<file>.</file>
 	<arg name="extensions" value="php,php5,inc"/>

diff --git a/composer.json b/composer.json
@@ -35,7 +35,7 @@
 		"justinrainbow/json-schema": ">=1.0",
 		"jakub-onderka/php-console-highlighter": "0.3.2",
 		"mediawiki/minus-x": "0.3.1",
-		"mediawiki/mediawiki-codesniffer": "26.0.0"
+		"mediawiki/mediawiki-codesniffer": "28.0.0"
 	},
 	"scripts": {
 		"test": [

diff --git a/src/LingoParser.php b/src/LingoParser.php
@@ -224,7 +224,7 @@ protected function realParse( &$parser ) {
 
 		// TODO: Remove call to \MediaWiki\suppressWarnings() for MW 1.34+.
 		// \Wikimedia\AtEase\AtEase::suppressWarnings() is available from MW 1.34.
-		if (method_exists( AtEase::class, 'suppressWarnings' ) ) {
+		if ( method_exists( AtEase::class, 'suppressWarnings' ) ) {
 			\Wikimedia\AtEase\AtEase::suppressWarnings();
 		} else {
 			\MediaWiki\suppressWarnings();
@@ -235,7 +235,7 @@ protected function realParse( &$parser ) {
 
 		// TODO: Remove call to \MediaWiki\restoreWarnings() for MW 1.34+.
 		// \Wikimedia\AtEase\AtEase::restoreWarnings() is available from MW 1.34.
-		if (method_exists( AtEase::class, 'suppressWarnings' ) ) {
+		if ( method_exists( AtEase::class, 'suppressWarnings' ) ) {
 			\Wikimedia\AtEase\AtEase::restoreWarnings();
 		} else {
 			\MediaWiki\restoreWarnings();

diff --git a/tests/phpunit/Integration/ArticleAnnotationTest.php b/tests/phpunit/Integration/ArticleAnnotationTest.php
@@ -53,7 +53,7 @@ public function setup() {
 		$GLOBALS[ 'wgexLingoDisplayOnce' ] = false;
 	}
 
-	public function tearDown() {
+	public function tearDown() : void {
 		// reset LingoParser singleton
 		$lingoParser = LingoParser::getInstance();
 		$reflection = new ReflectionClass( $lingoParser );

diff --git a/tests/phpunit/Unit/ElementTest.php b/tests/phpunit/Unit/ElementTest.php
@@ -44,7 +44,7 @@ class ElementTest extends \PHPUnit\Framework\TestCase {
 	protected $element;
 	protected $doc;
 
-	protected function setUp() {
+	protected function setUp() : void {
 		$this->doc = new \DOMDocument();
 	}